fix(editor): Fix dialogVisibleChanged hooks event when meta.value is undefined (no-changelog) #7986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
elsmr
approved these changes
Dec 14, 2023
Passing run #3341 ↗︎
Details:
Review all test suite changes for PR #7986 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
alexgrozav
deleted the
n8n-7084-typeerror-evalueslice-is-not-a-function-in-evalueslice1
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 15, 2023
* master: refactor(core): Warn on sqlite DB detected during init on queue mode (#8034) docs: Two small UI copy fixes in sub-nodes (#8032) fix(core): Restore workflow ID during execution creation (#8031) fix(core): Initialize queue once in queue mode (#8025) fix(editor): Add back credential `use` permission (#8023) fix(editor): Disable auto scroll and list size check when clicking on executions (#7983) fix(editor): Fix dialogVisibleChanged hooks event when meta.value is undefined (no-changelog) (#7986) perf(editor): Improve canvas rendering performance (#8022)
ivov
pushed a commit
that referenced
this pull request
Dec 15, 2023
…undefined (no-changelog) (#7986) ## Summary Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended. In specific scenarios `meta.value` can come as `undefined`, causing the hook to fail. #### How to test the change: 1. Close Expression editor modal dialog with empty value ## Issues fixed Include links to Github issue or Community forum post or **Linear ticket**: > Important in order to close automatically and provide context to reviewers https://linear.app/n8n/issue/N8N-7084/typeerror-evalueslice-is-not-a-function-in-evalueslice1-evalueslice-is https://n8nio.sentry.io/issues/4715787194/ ## Review / Merge checklist - [x] PR title and summary are descriptive. **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** ([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md)) - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. > A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. > > *(internal)* You can use Slack commands to trigger [e2e tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227) or [deploy test instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce) or [deploy early access version on Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
|
Got released with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended.
In specific scenarios
meta.valuecan come asundefined, causing the hook to fail.How to test the change:
Issues fixed
Include links to Github issue or Community forum post or Linear ticket:
https://linear.app/n8n/issue/N8N-7084/typeerror-evalueslice-is-not-a-function-in-evalueslice1-evalueslice-is
https://n8nio.sentry.io/issues/4715787194/
Review / Merge checklist
(no-changelog)otherwise. (conventions)