Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add health check endpoint #15

Merged
merged 10 commits into from
Nov 22, 2024
Merged

feat: Add health check endpoint #15

merged 10 commits into from
Nov 22, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 22, 2024

@ivov ivov marked this pull request as draft November 22, 2024 10:16
@ivov ivov marked this pull request as ready for review November 22, 2024 10:40
@ivov ivov marked this pull request as draft November 22, 2024 10:51
@ivov ivov marked this pull request as ready for review November 22, 2024 11:08
tomi
tomi reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌 Only couple tiny things

internal/http/healthcheck_server.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ivov ivov requested a review from tomi November 22, 2024 12:47
tomi
tomi approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ivov ivov merged commit e7b3a38 into main Nov 22, 2024
2 checks passed
@ivov ivov deleted the healthcheck-endpoint branch November 22, 2024 15:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivov @tomi