Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Encapsulate runner config operations #30

Merged
merged 2 commits into from
Nov 27, 2024
Merged

refactor: Encapsulate runner config operations #30

merged 2 commits into from
Nov 27, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 27, 2024

Move all runner config related logic to the config package.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/config/config.go 0.00% 23 Missing ⚠️
internal/commands/launch.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

tomi
tomi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ivov ivov merged commit ba438fa into main Nov 27, 2024
2 checks passed
@ivov ivov deleted the encapsulate-runner-config-operations branch November 27, 2024 10:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @codecov-commenter @tomi