Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: Display excluded env vars in debug logs #56

Merged
merged 2 commits into from
Dec 11, 2024
Merged

refactor: Display excluded env vars in debug logs #56

merged 2 commits into from
Dec 11, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Dec 10, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ivov
Copy link
Contributor Author

ivov commented Dec 10, 2024

Example:

2024/12/10 15:32:50 INFO  Starting launcher...
2024/12/10 15:32:50 INFO  Starting launcher's health check server at port 5680
2024/12/10 15:32:50 DEBUG Changed into working directory: /Users/ivov/Development/task-runner-launcher/bin
2024/12/10 15:32:50 DEBUG Env vars to exclude from runner: [ATUIN_HISTORY_ID ATUIN_SESSION COLORFGBG C
OLORTERM COMMAND_MODE COVERAGE_REPORT DEV_DIR DISABLE_AUTO_TITLE GOPATH HOME HOMEBREW_CELLAR HOMEBREW_PREFIX HOMEBREW_REPOSITORY INFOPATH ITERM_PROFILE ITERM_SESSION_ID KUBE_EDITOR LC_TERMINAL LC_TERMINAL_VERSION LESS LOGNAME LSCOLORS LS_COLORS LaunchInstanceID N8N_DEPLOYMENT_TYPE N8N_DIAGNOSTICS_ENABLED N8N_ENCRYPTION_KEY N8N_HIRING_BANNER_ENABLED N8N_LICENSE_ACTIVATION_KEY N8N_LICENSE_TENANT_ID N8N_LOG_LEVEL N8N_RUNNERS_AUTH_TOKEN N8N_RUNNERS_LAUNCHER_LOG_LEVEL N8N_RUNNERS_TASK_TIMEOUT NODEJS_PREFER_IPV4 N_PRESERVE_COREPACK OFFLOAD_MANUAL_EXECUTIONS_TO_WORKERS OLDPWD P9K_SSH P9K_TTY PAGER PNPM_HOME PWD SECURITYSESSIONID SHELL SHLVL SSH_AUTH_SOCK TERMINFO_DIRS TERM_FEATURES TERM_PROGRAM TERM_PROGRAM_VERSION TERM_SESSION_ID TMPDIR TMUX TMUX_PANE TMUX_PLUGIN_MANAGER_PATH USER XPC_FLAGS XPC_SERVICE_NAME ZSH _ _P9K_TTY __CFBundleIdentifier __CF_USER_TEXT_ENCODING]
2024/12/10 15:32:50 DEBUG Env vars to pass to runner: [LANG PATH TERM N8N_RUNNERS_HEALTH_CHECK_SERVER_ENABLED N8N_RUNNERS_AUTO_SHUTDOWN_TIMEOUT N8N_RUNNERS_TASK_TIMEOUT]
2024/12/10 15:32:50 INFO  Waiting for task broker to be ready...

tomi
tomi approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👍

@ivov ivov merged commit 316bbfa into main Dec 11, 2024
2 checks passed
@ivov ivov deleted the refactor-display-excluded-env-vars-in-debug-logs branch December 11, 2024 12:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomi tomi tomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @codecov-commenter @tomi