Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update RF24Gateway_ncurses.cpp #29

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Feb 16, 2024

Minor change to prevent segfault on non-master nodes

Minor change to prevent segfault on non-master nodes
github-actions[bot]

This comment was marked as outdated.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@2bndy5
Copy link
Member

2bndy5 commented Feb 16, 2024

If you don't want the bot to spam the PR thread, then make the PR a "draft" instead of a normal PR that's ready for review.

image
or
image

@2bndy5
Copy link
Member

2bndy5 commented Feb 16, 2024

There seems to build errors about the net layers template specializations:

[ 50%] Building CXX object CMakeFiles/rf24gateway.dir/RF24Gateway.cpp.o
In file included from /home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.cpp:7:
/home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.h:43:7: error: using typedef-name ‘RF24Network’ after ‘class’
   43 | class RF24Network;
      |       ^~~~~~~~~~~
In file included from /home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.h:29,
                 from /home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.cpp:7:
/usr/arm-linux-gnueabihf/include/RF24Network/RF24Network.h:992:26: note: ‘RF24Network’ has a previous declaration here
  992 | typedef ESBNetwork<RF24> RF24Network;
      |                          ^~~~~~~~~~~
In file included from /home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.cpp:7:
/home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.h:44:7: error: using typedef-name ‘RF24Mesh’ after ‘class’
   44 | class RF24Mesh;
      |       ^~~~~~~~
In file included from /home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.h:30,
                 from /home/runner/work/RF24Gateway/RF24Gateway/RF24Gateway/RF24Gateway.cpp:7:
/usr/arm-linux-gnueabihf/include/RF24Mesh/RF24Mesh.h:384:41: note: ‘RF24Mesh’ has a previous declaration here
  384 | typedef ESBMesh<ESBNetwork<RF24>, RF24> RF24Mesh;
      |                                         ^~~~~~~~
gmake[2]: *** [CMakeFiles/rf24gateway.dir/build.make:76: CMakeFiles/rf24gateway.dir/RF24Gateway.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/rf24gateway.dir/all] Error 2
gmake: *** [Makefile:156: all] Error 2

Not sure why this is happening now and wasn't before, but I'm stopping for now (need to sleep)...

@TMRh20
Copy link
Member Author

TMRh20 commented Feb 16, 2024 via email

@2bndy5
Copy link
Member

2bndy5 commented Feb 17, 2024

I didn't realize this branch is based on 1.x branch instead of master (2.x). And the CI is using v2.x of RF24Network & RF24Mesh libs. Luckily, I have already foreseen this, so it was an easy fix in the CI yml file.

@TMRh20
Copy link
Member Author

TMRh20 commented Feb 17, 2024

Yeah, I forgot what I was doing earlier and this had me a bit confused for a moment too.

@TMRh20 TMRh20 merged commit ea6e953 into v1.x Feb 17, 2024
4 checks passed
@2bndy5 2bndy5 deleted the Minor-change-for-ncurses-example branch February 17, 2024 12:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants