Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Warnings if unable to config interface #39

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Warnings if unable to config interface #39

merged 3 commits into from
Jun 23, 2024

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Jun 19, 2024

  • Add some warnings with detailed descriptions of the problem and what to do if configuration of the network interface fails (usually because not running as root)

github-actions[bot]

This comment was marked as resolved.

# to view

@github-actions github-actions bot dismissed their stale review June 19, 2024 16:57

outdated suggestion

@2bndy5
Copy link
Member

2bndy5 commented Jun 19, 2024

I think we can programmatically fetch the user name using getlogin().

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 19, 2024

Great idea! I've added getlogin() calls to modify the commands provided to the user now!

@TMRh20 TMRh20 requested a review from 2bndy5 June 22, 2024 20:24
@TMRh20 TMRh20 merged commit f3dfd17 into master Jun 23, 2024
8 checks passed
@TMRh20 TMRh20 deleted the root_warnings branch June 23, 2024 14:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TMRh20 @2bndy5