refactor: add tests and slim down on #178 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(example-app): types ref * chore: inject browser-scope helpers/tools
* feat(test): improved multiversion script - add test script for executing the multiversion easier - use path.resolve to execute the script independent from the current folder location * feat: introduce minimum required ui5 version - throw error when the ui5 version is lower than 1.60 * feat: use nightly cdn for multiversion to also get "SNAPSHOT" versions * feat: use semver for version comparsion * feat: awareness of different versions - instantiate the matchers correctly below ui5 version 1.72 * feat: add dedicated properties-matcher test script - remove ui5 version below 1.60 from multiversion tests * feat: correct awarness of ui5 versions - remove "getUI5VersionAsFloat" as it will not return the correct version - remove usage of "getUI5VersionAsFloat" from test scripts * feat: remove unnecessary "debugger" line in injectUI5.js
|
hi, i took the liberty and merged this PR along with your original contribution into ui5-community#189 - please don't take this as an "overruling" of any kind, it's for the sole reason that we want to release |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, first of all, thanks for the original PR on adding custom tags to the logger 👍
much appreciated 🙌
i took the liberty to use your PR as opportunity to
let me know what you think, then let's get this into
wdi5!