add(clientStore): try to speed up things #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflows: * update runs-on code: * instead of looking up the clientId 2 find we bulk with both in same lookup * URL is deprecated, use URI().toURL() * add findClients to clientRegistry * add findClients to ClientStore, to map * update upserQuery to only do update if there is changes to data mock: * update mocks Tests * tests new behaviour to storeClients * add test for findClients * simple benchmark, comparing find and findClients consider: validating audience input
|
ikke bry om den detekt, skal fjerne det å bruke |
tronghn
approved these changes
Dec 11, 2024
src/main/kotlin/io/nais/security/oauth2/routing/TokenExchangeApi.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/io/nais/security/oauth2/registration/ClientStoreTest.kt
Outdated
Show resolved
Hide resolved
tommytroen
approved these changes
Dec 12, 2024
* setup clientId in tokenRequestContext * split up tests make them a little more robust with a warmup method
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflows:
code:
mock:
Tests
consider:
validating audience input
cache of client data , either inmem or redis
cache of jwks is 6 hours, should it be longer?