Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow a mouseOver text for buttons #232

Merged
merged 2 commits into from
Nov 14, 2016

Conversation

tabacha
Copy link

@tabacha tabacha commented Jan 24, 2016

Hi,
thank you for your libary. I would like to add a mouseOver text to a button:

BootstrapDialog.show({
            message: 'Hi Apple!',
            buttons: [{
                label: 'Button 1',
                mouseOver: 'Mouse over Button 1'
            }, 
..

@nakupanda
Copy link
Owner

Hi,

Thanks for this code contribution.
'mouseOver' looks more like an even handler rather than a text hint, how about we name it just as 'title':

...
label: 'Button 1',
title: 'This is button 1',
action: ..

@tabacha
Copy link
Author

tabacha commented Jan 30, 2016

I do not like 'title' so much, because I see no difference between label and title. The effect of title is a mouseOver Popup.
But I can change this. You are the owner of the project and have the dessission.

Do you like: mousOverPopupText

@matusferko
Copy link

Hi,
as per source code it's just html 'title' attribute. I vote for 'title' property :)

@nakupanda
Copy link
Owner

@Coffy thanks for the vote :)

@tabacha , there is nothing to do with the project ownership.
'mousOverPopupText' obviously looks too long, and as the idea owner, you don't like it to be 'title', so how about 'tooltip' ?

@tabacha
Copy link
Author

tabacha commented Feb 7, 2016

tooltip sounds also good

@zeckdude
Copy link
Contributor

+1 for tooltip

@tabacha
Copy link
Author

tabacha commented Nov 12, 2016

@nakupanda can you please merge this pr?

@nakupanda nakupanda merged commit 9bad0c6 into nakupanda:master Nov 14, 2016
nakupanda added a commit that referenced this pull request Nov 14, 2016
nakupanda added a commit that referenced this pull request Nov 14, 2016
@nakupanda
Copy link
Owner

Done merging, thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants