Feature/registry api fixes #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
approved these changes
Oct 29, 2020
oleh-momot
approved these changes
Oct 29, 2020
| @@ -7,10 +7,17 @@ import db from '../../db'; | |||
| import preProcessResponse from '../../common/services/preProcessResponse'; | |||
|
|
|||
| const getApps = async (req: Request, res: Response): Promise<void> => { | |||
| const apps = await db.select().from('apps'); | |||
| let filters = req.query.filter ? JSON.parse(req.query.filter as string) : {}; | |||
There was a problem hiding this comment.
I am not sure that we have to use let here because no chances are it can be changed
| export const prepareAppRoutesToRespond = _.compose( | ||
| prepareRoutesWithSlotsToRespond, | ||
| ); | ||
| export const prepareAppRoutesToRespond = (v: any[]) => v.map(row => prepareRouteToRespond(row)) |
There was a problem hiding this comment.
You may use _.map here
export const prepareAppRoutesToRespond = _.map(prepareRouteToRespond)
There was a problem hiding this comment.
I think use of native method is better
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.