-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: added coverage text reporting npm command for ilc #303
Conversation
ilc/package.json
Outdated
@@ -8,6 +8,7 @@ | |||
"test:ci": "npm run test -- --forbid-only", | |||
"test:watch": "npm run test -- --watch", | |||
"test:coverage": "cross-env NODE_ENV=test nyc mocha", | |||
"test:coverage-text": "cross-env NODE_ENV=test nyc --reporter=text mocha", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StyleT Probably that might be useful for someone to check the coverage quickly and be sure about whether they have covered all mandatory lines.
I'm using that for analysis to be sure whether I have missed covering some conditions/lines or maybe that doesn't make sense in some context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you instead change config of the npm run test:coverage
so it would produce text report alongside with html? Should fulfil your needs, enhance CI output while ensuring that we don't have "unused" scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for me, it looks like a useful reminder to cover all files with tests :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StyleT agreed.
Just was concerning to have some redundant output upon CI building.
I've made a new commit with replaced text reporter output into default coverage reporting configuration.
Could you please have a look
Just useful thing upon development to check the general coverage via terminal