Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: added coverage text reporting npm command for ilc #303

Merged
merged 2 commits into from
May 27, 2021

Conversation

ifree92
Copy link
Contributor

@ifree92 ifree92 commented May 25, 2021

Just useful thing upon development to check the general coverage via terminal

ilc/package.json Outdated
@@ -8,6 +8,7 @@
"test:ci": "npm run test -- --forbid-only",
"test:watch": "npm run test -- --watch",
"test:coverage": "cross-env NODE_ENV=test nyc mocha",
"test:coverage-text": "cross-env NODE_ENV=test nyc --reporter=text mocha",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StyleT Probably that might be useful for someone to check the coverage quickly and be sure about whether they have covered all mandatory lines.

I'm using that for analysis to be sure whether I have missed covering some conditions/lines or maybe that doesn't make sense in some context.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you instead change config of the npm run test:coverage so it would produce text report alongside with html? Should fulfil your needs, enhance CI output while ensuring that we don't have "unused" scripts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as for me, it looks like a useful reminder to cover all files with tests :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StyleT agreed.
Just was concerning to have some redundant output upon CI building.

I've made a new commit with replaced text reporter output into default coverage reporting configuration.
Could you please have a look

@ifree92 ifree92 requested a review from nightnei May 25, 2021 15:40
@ifree92 ifree92 requested a review from StyleT May 26, 2021 11:56
@ifree92 ifree92 merged commit dd251cb into master May 27, 2021
@ifree92 ifree92 deleted the addIlcCoverageTextReporterCommand branch May 27, 2021 08:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants