feat: added ability to conveniently get hostname from client/server API of the Transition hooks plugin #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI of the Transition hooks plugin
ifree92
approved these changes
May 31, 2021
nightnei
reviewed
May 31, 2021
| @@ -34,10 +34,12 @@ export default class GuardManager { | |||
| route: { | |||
| meta: route.meta, | |||
| url: route.reqUrl, | |||
| hostname: window.location.hostname, | |||
There was a problem hiding this comment.
it's minor but I think it's a little bit better to use host instead of hostname. what do you think?
There was a problem hiding this comment.
Nope :) http://bl.ocks.org/abernier/3070589 I would work inconsistently with SSR then.
nightnei
approved these changes
May 31, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.