fix: case when CSS removed immediately but due to spinner cloned node… #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of application is still alive. Generic logic of ILC when spinner is enabled is that app is unmounted, but original app node is cloned in DOM and alive while spinner is in progress. That is why if spinner is enabled CSS should not be removed from DOM immediately, instead we need to wait for all transitions and remove CSS only then.
blackrabbit99
approved these changes
Jul 5, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of application is still alive.
Generic logic of ILC when spinner is enabled is that app is unmounted, but original app node is cloned in DOM and alive while spinner is in progress. That is why if spinner is enabled CSS should not be removed from DOM immediately, instead we need to wait for all transitions and remove CSS only then.