Skip to content

Commit

Permalink
Merge pull request #2 from kitagry/return-empty-array
Browse files Browse the repository at this point in the history
Return empty array when golangci-lint return empty
  • Loading branch information
nametake authored Mar 15, 2020
2 parents 9db5546 + 3ba99d5 commit 0ee3aa9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,23 @@ type langHandler struct {
}

func (h *langHandler) lint(uri DocumentURI) ([]Diagnostic, error) {
diagnostics := make([]Diagnostic, 0)

//nolint:gosec
cmd := exec.Command(h.command[0], h.command[1:]...)

b, err := cmd.CombinedOutput()
if err == nil {
return nil, nil
return diagnostics, nil
}

var result GolangCILintResult
if err := json.Unmarshal(b, &result); err != nil {
return nil, err
return diagnostics, err
}

h.logger.DebugJSON("golangci-lint-langserver: result:", result)

diagnostics := make([]Diagnostic, 0)

for _, issue := range result.Issues {
issue := issue

Expand Down

0 comments on commit 0ee3aa9

Please # to comment.