Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v0.0.8 breaks when go.mod is not in repo root #33

Open
thejan2009 opened this issue Mar 30, 2023 · 1 comment
Open

v0.0.8 breaks when go.mod is not in repo root #33

thejan2009 opened this issue Mar 30, 2023 · 1 comment

Comments

@thejan2009
Copy link
Contributor

The issue was introduced with #25. Cmd breaks when the go.mod is located in a subpath. Example structure:

project
├── .git
└── go
    ├── go.mod
    └── main.go

One way to solve this would be finding the go mod root. go env GOMOD returns the correct value or os.DevNull if if can't find one.

@thejan2009
Copy link
Contributor Author

I opened a fix PR in golangci-lint golangci/golangci-lint#3748 and propose the changes from v0.0.8 are partially reverted.

fredrikaverpil added a commit to fredrikaverpil/dotfiles that referenced this issue Jun 1, 2024
Apparently, there's an issue with the golangci-lint LSP:
nametake/golangci-lint-langserver#33
kerumitdg added a commit to kerumitdg/dotfiles that referenced this issue Jul 2, 2024
Apparently, there's an issue with the golangci-lint LSP:
nametake/golangci-lint-langserver#33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant