Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix response to initialize #4

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Fix response to initialize #4

merged 1 commit into from
Oct 24, 2020

Conversation

fsouza
Copy link
Contributor

@fsouza fsouza commented Oct 23, 2020

golangci-lint-langserver doesn't really handle didChange, and when
TextDocumentSync is set to a number, it affects the behavior of
didChange. Without this change, more strict clients won't send the
textDocument/didSave notification.

With this change, I'm able to use golangci-lint-langserver with neovim's
builtin lsp client.

golangci-lint-langserver doesn't really handle didChange, and when
TextDocumentSync is set to a number, it affects the behavior of
didChange. Without this change, more strict clients won't send the
textDocument/didSave notification.

With this change, I'm able to use golangci-lint-langserver with neovim's
builtin lsp client.
fsouza added a commit to fsouza/dotfiles that referenced this pull request Oct 23, 2020
Along with golangci-lint. Installing from a fork until
nametake/golangci-lint-langserver#4 is merged.
Copy link
Owner

@nametake nametake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nametake nametake merged commit 1cba20d into nametake:master Oct 24, 2020
@fsouza fsouza deleted the fix-server-capabilities branch October 24, 2020 01:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants