Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: sequences work again on reanimated 2.3+ #200

Merged

Conversation

jstheoriginal
Copy link
Contributor

See: #195

TL;DR: The getSequenceArray incline function isn't automatically workletized by reanimated 2.3+, which caused crashes/freezing when using a sequence on iOS and Android on anything over reanimated 2.2.4.

The fix just involves moving it out to the file level, adding 'worklet', and passing in any needed params.

Closes #195

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
moti ❌ Failed (Inspect) May 26, 2022 at 7:18PM (UTC)

@nandorojo nandorojo merged commit a976caf into nandorojo:master Jul 21, 2022
@nandorojo nandorojo mentioned this pull request Jul 26, 2022
@nandorojo
Copy link
Owner

nandorojo commented Jul 26, 2022

Published to 0.19.0-alpha.2:

yarn add moti@canary

Please see #215 for the upgrade guide.

@hirbod
Copy link

hirbod commented Aug 5, 2022

I installed canary, but sequences are still crashing for me.
I am not at rea 3, but 2.9.1 - it that the issue?

      <MotiView
        style={{ width: '100%' }}
        animate={{
          scale: [0, 1.1, { value: 1, delay: 200 }], // scale to 0, 1.1, then 1 (with delay 200 ms)
        }}
      >

Bildschirmfoto 2022-08-05 um 11 01 41

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence not working since reanimated 2.3.0
3 participants