Skip to content

Improve GetLogs function #83

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve GetLogs function #83

wants to merge 1 commit into from

Conversation

FournyP
Copy link

@FournyP FournyP commented Oct 28, 2023

Hi,

I've improved the GetLogs function because some of mandatory parameters are not mandatory for the etherscan API (e.g: toBlock, fromBlock and topic).

I've also add missing parameter page and offset.

Tests execution:
image

Feel free to ask me any change in my codebase

Have a good day ;)

@nanmu42
Copy link
Owner

nanmu42 commented Oct 28, 2023

Hi, @FournyP , thanks for your contribution!

I would love to see it merged but we cannot alter an existed API.
I recommend to implement it as a new method GetLogsByAddr(or choose a name in your flavor).

Cheers.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants