Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Local engine doesn't get copied or used #603

Closed
glinton opened this issue Oct 23, 2017 · 3 comments
Closed

Local engine doesn't get copied or used #603

glinton opened this issue Oct 23, 2017 · 3 comments
Assignees

Comments

@glinton
Copy link
Contributor

glinton commented Oct 23, 2017

Example boxfile.yml: (· represent space)

run.config:
··engine:·../python·
@glinton glinton changed the title Local engine breaks if there is a space after definition Local engine doesn't get copied or used Oct 23, 2017
@glinton
Copy link
Contributor Author

glinton commented Oct 23, 2017

Turns out the sync fails even without a space and with the proper path.

    - Copying engine :
       sync:               0 100%    0.00kB/s    0:00:00 (xfr#0, to-chk=0/1)

@danhunsaker
Copy link
Contributor

Trailing whitespace should always be removed, everywhere. I mean, we shouldn't have to strip it ourselves, but still. Trailing whitespace is anathema.

@glinton
Copy link
Contributor Author

glinton commented Oct 23, 2017

Yes, turns out it is has nothing to do with this issue though. I falsely assumed my first run (with no trailing whitespace) worked. Since the hooks handle and parse the boxfile my guess is nanobox isn't mounting in the engine to be rsynced from the specified location.

It is planned to incorporate the boxfile validation in nanobox itself, so as to save time before finding out a bad node was entered, but there is much in the plans (so no solid ETA).

glinton added a commit that referenced this issue Oct 24, 2017
Turns out when we renamed boxfile nodes, we never updated nanobox to
match. This addresses that and properly mounts in a specified local
engine as well as cleans up the mount should a user stop using the local
engine.

Resolves #603
@glinton glinton self-assigned this Oct 24, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants