Check for boxfile and validate in separate steps #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflint
reviewed
Aug 11, 2017
util/display/messages.go
Outdated
| -------------------------------------------------------------------------------- | ||
| INVALID BOXFILE.YML | ||
| Nanobox requires valid yaml in your boxfile.yml config file. Paste the contents | ||
| of your boxfile into yamllint.com to validate. |
There was a problem hiding this comment.
I generally try to add a "please" whenever asking users to do something. In this case, "Please paste the..."
Also, I would probably use the full domain: www.yamllint.com
Looks good!
If no boxfile.yml was present, nanobox would traverse up the directory tree looking for a boxfile and use that to build and would set that as the mountpoint. Turns out we still want that behavior so I'll put it in somewhere else maybe.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes bug where nanobox uses a boxfile from a level up if none is found in the cwd
Resolves #501
Resolves #510