Simplifying bootstrap_attempt::mode_text and returning the direct cha…

…r const * instead of converting it to std::string. (#3869)

nano/node/bootstrap/bootstrap_attempt.cpp

@@ -95,22 +95,18 @@ void nano::bootstrap_attempt::stop ()
 	node->bootstrap_initiator.connections->clear_pulls (incremental_id);
 }
 
-std::string nano::bootstrap_attempt::mode_text ()
+char const * nano::bootstrap_attempt::mode_text ()
 {
-	std::string mode_text;
-	if (mode == nano::bootstrap_mode::legacy)
+	switch (mode)
 	{
-		mode_text = "legacy";
+		case nano::bootstrap_mode::legacy:
+			return "legacy";
+		case nano::bootstrap_mode::lazy:
+			return "lazy";
+		case nano::bootstrap_mode::wallet_lazy:
+			return "wallet_lazy";
 	}
-	else if (mode == nano::bootstrap_mode::lazy)
-	{
-		mode_text = "lazy";
-	}
-	else if (mode == nano::bootstrap_mode::wallet_lazy)
-	{
-		mode_text = "wallet_lazy";
-	}
-	return mode_text;
+	return "unknown";
 }
 
 bool nano::bootstrap_attempt::process_block (std::shared_ptr<nano::block> const & block_a, nano::account const & known_account_a, uint64_t pull_blocks_processed, nano::bulk_pull::count_t max_blocks, bool block_expected, unsigned retry_limit)

nano/node/bootstrap/bootstrap_attempt.hpp

@@ -26,7 +26,7 @@ class bootstrap_attempt : public std::enable_shared_from_this<bootstrap_attempt>
 	void pull_started ();
 	void pull_finished ();
 	bool should_log ();
-	std::string mode_text ();
+	char const * mode_text ();
 	virtual bool process_block (std::shared_ptr<nano::block> const &, nano::account const &, uint64_t, nano::bulk_pull::count_t, bool, unsigned);
 	virtual void get_information (boost::property_tree::ptree &) = 0;
 	virtual void block_processed (nano::transaction const & tx, nano::process_return const & result, nano::block const & block);