Skip to content

Commit

Permalink
Fix for RPC stop command (#3191)
Browse files Browse the repository at this point in the history
The RPC stop command was not working (the node did exit completely)
because the stop callback was never called because the callback was
called after the node was stopped and the stop callback needed the node
to execute.

This commit removes the node stop before the callback and let's the
stop call back execute, which should stop io_ctx after 3 seconds, which
in turn should exit the daemon and the node should be stopped by its
destructor.
  • Loading branch information
dsiganos authored and theohax committed Oct 20, 2021
1 parent 8602d35 commit 87e005c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion nano/node/json_handler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3826,7 +3826,6 @@ void nano::json_handler::stop ()
response_errors ();
if (!ec)
{
node.stop ();
stop_callback ();
}
}
Expand Down

0 comments on commit 87e005c

Please # to comment.