Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Counting of voting representatives is wrong (no check for duplicates) #3339

Closed
dsiganos opened this issue Jun 16, 2021 · 1 comment · Fixed by #3340
Closed

Counting of voting representatives is wrong (no check for duplicates) #3339

dsiganos opened this issue Jun 16, 2021 · 1 comment · Fixed by #3340
Milestone
V23.0

Comments

@dsiganos
Copy link
Contributor

Summary

The function rep wallets::rep_check() did not check for duplicates when adding a voting representative and the count of voting representatives could therefore be much bigger than the reality.

Node version

V22.1

Build details

Manual build.

OS and version

Ubuntu 20.04

Steps to reproduce the behavior

  1. Run test case node.rep_self_vote it fails about once in a 1000 iterations.

Expected behavior

check_rep should not count duplicate entries.

Actual behavior

It counts duplicates.

Possible solution

No response

Supporting files

No response
dsiganos added a commit to dsiganos/nano-node that referenced this issue Jun 16, 2021
@dsiganos
Fix counting of voting representatives nanocurrency#3339
e22b686 
The function rep wallets::rep_check() did not check for duplicates when
adding a voting representative and the count of voting representatives
could therefore be much bigger than the reality.
clemahieu pushed a commit that referenced this issue Jun 16, 2021
@dsiganos
Fix counting of voting representatives #3339 (#3340)
6ee3cee 
The function rep wallets::rep_check() did not check for duplicates when
adding a voting representative and the count of voting representatives
could therefore be much bigger than the reality.
@zhyatt zhyatt linked a pull request Jun 22, 2021 that will close this issue
Fix counting of voting representatives #3339 #3340
Merged
@zhyatt zhyatt added this to the V23.0 milestone Jun 22, 2021
@zhyatt
Copy link
Collaborator

zhyatt commented Jun 22, 2021

Closed by #3340

@zhyatt zhyatt closed this as completed Jun 22, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V23.0
Development

Successfully merging a pull request may close this issue.

Fix counting of voting representatives #3339 dsiganos/nano-node
2 participants
@zhyatt @dsiganos