Get rid of nounset flag when running the Boost bootstrap subscript #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to bugs in bash empty arrays are treated as unset, but we use empty arrays in some conditions in the boost bootstrap script. When calling that script from the build prep script by inclusion, remove the nounset flag so that empty arrays can be used as empty arrays.
argakiig
approved these changes
Jan 3, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bugs in bash empty arrays are treated as unset, but we use empty
arrays in some conditions in the boost bootstrap script. When calling
that script from the build prep script by inclusion, remove the nounset
flag so that empty arrays can be used as empty arrays.