Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expanding root to uint512_union #1600

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Expanding root to uint512_union #1600

merged 2 commits into from
Jan 17, 2019

Conversation

rkeene
Copy link
Contributor

@rkeene rkeene commented Jan 17, 2019

No description provided.

@rkeene rkeene added this to the V17.1 milestone Jan 17, 2019
@rkeene rkeene requested a review from SergiySW January 17, 2019 03:02
SergiySW
SergiySW approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@SergiySW SergiySW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergiySW
Copy link
Contributor

May be we can replace nano::uint512_union (block->previous (), block->root ()) with something like block->qualified_root () later to simplify code

@rkeene rkeene merged commit e5999ba into nanocurrency:master Jan 17, 2019
rkeene added a commit that referenced this pull request Jan 17, 2019
@rkeene
Expanding root to uint512_union (#1600)
04a0259
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

Assignees

@clemahieu clemahieu

@SergiySW SergiySW

Labels
enhancement
Projects
None yet
Milestone
V17.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rkeene @SergiySW @clemahieu