Remove circular dependency between secure <-> lib libraries #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
clemahieu
approved these changes
Mar 27, 2019
|
Thanks! |
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Apr 15, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any mention of secure in the lib library. The secure library has a few dependencies on the lib library, while the
liblibrary currently has a dependency on thekeypairclass which is part of the secure library (which also currently has circular dependencies with the node library), this was part of a larger classnetwork_params. A lot of this code used to be in the secure library before, so I've just moved it back. However it is necessary to know logic like which network we are on (test/live/beta) in the future RPC stuff so a new class network_constants has been created which incorporates this in the lib library.