Makes sure a write lock can be avoided when launching an inactive_node #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI commands can currently open a write lock on the ledger database when they don't need to. When using
--fast_bootstrapand aren't synced yet or if there is any other long write transaction running, simple commands likenano_node --wallet_createcan end up taking a few minutes. A few places where writes were being used are now checked in a pre-pass by using a read transaction to see whether the write is actually required (after first initialization of the ledger, they generally aren't needed).I found that the read transaction needs to be committed when opening databases (not sure why), but I've replaced abort with that. This is also what it is prior to #1951.