Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean up json upgrade code/unused variables #1993

Merged
merged 1 commit into from
May 17, 2019
Merged

Clean up json upgrade code/unused variables #1993

merged 1 commit into from
May 17, 2019

Conversation

cryptocode
Copy link
Contributor

Uses the pattern of returning version_a < json_version () everywhere, which should be less error-prone/less code. Also moves the network variable within the ifdef where it's used.

@cryptocode cryptocode added this to the V19.0 milestone May 16, 2019
@cryptocode cryptocode requested a review from wezrule May 16, 2019 23:16
@cryptocode cryptocode self-assigned this May 16, 2019
@cryptocode cryptocode merged commit f8da09f into nanocurrency:master May 17, 2019
@cryptocode cryptocode deleted the cleanup/unnecessary-variables branch May 17, 2019 13:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wezrule wezrule wezrule approved these changes

Assignees

@cryptocode cryptocode

Labels
non-functional change
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptocode @wezrule