Fix initialization order bug in nano::node #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wallets; no initialization order will do
wezrule
approved these changes
May 29, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 11, 2019
* Fix initialization order bug in nano::node * Use a latch to deal with mutual deps between active transactions and wallets; no initialization order will do * Remove counter from initializer list as it's just calling the default ctor
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wallet depends on confirmation_height_processor, and search_pending sometimes calls it before the node is fully constructed, causing a segfault.