Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move WebSocket confirmation_type into message #2079

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Move WebSocket confirmation_type into message #2079

merged 1 commit into from
Jun 13, 2019

Conversation

cryptocode
Copy link
Contributor

json on Discord pointed out the confirmation_type field is at the level above the message node. Makes more sense to put it in the message.

@cryptocode cryptocode added documentation This item indicates the need for or supplies updated or expanded documentation websockets labels Jun 13, 2019
@cryptocode cryptocode added this to the V19.0 milestone Jun 13, 2019
@cryptocode cryptocode requested a review from SergiySW June 13, 2019 10:44
@cryptocode cryptocode self-assigned this Jun 13, 2019
@cryptocode cryptocode merged commit 335b955 into nanocurrency:master Jun 13, 2019
@cryptocode cryptocode deleted the websocket/move_confirmation_type_into_message branch June 13, 2019 15:06
argakiig pushed a commit that referenced this pull request Jun 27, 2019
@cryptocode
Move WebSocket confirmation_type into message (#2079)
8886ab2
@zhyatt zhyatt added quality improvements This item indicates the need for or supplies changes that improve maintainability and removed documentation This item indicates the need for or supplies updated or expanded documentation labels Jul 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

Assignees

@cryptocode cryptocode

Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability websockets
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptocode @SergiySW @zhyatt