Add observer stats for confirmations #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
added
the
incomplete
wezrule
removed
the
incomplete
wezrule
approved these changes
Jun 23, 2019
argakiig
pushed a commit
that referenced
this pull request
Jun 27, 2019
* Add observer stats for confirmations * Test that observer stats are updated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observer stats facilitate debugging callbacks and websockets. The subtotal for stats "observer/confirmation*" should match the stat "confirmation/blocks_confirmed" if everything works as expected (notification is async so numbers may be slightly out of sync for short periods of time)
If a websocket client has a different count, it indicates a bug in websockets, the external client, or the configuration/subscription (though beware intermittent network issues may cause lost messages as WS doesn't guarantee delivery; a queue system like mqtt is needed for that)