Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve broadcast_confirm_req_batch delays and max size #2130

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Improve broadcast_confirm_req_batch delays and max size #2130

merged 2 commits into from
Jul 5, 2019

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Jul 5, 2019

Batch confirm_req by hash/root:

  • removed increased delay for each iteration. It could cause much longer confirmations without change (+50 ms each iteration)
  • larger max reps limit should allow more aggressive & faster confirmation
  • better load balancing across multiple representatives in each iteration

@SergiySW
Improve broadcast_confirm_req_batch delays and max size
ae367b3 
Batch confirm_req by hash/root:
* removed increased delay for each iteration. It could cause much longer confirmations without change (+50 ms each iteration)
* larger max reps limit should allow more aggressive & faster confirmation
* better load balancing across multiple representatives in each iteration
@SergiySW SergiySW added bug functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality labels Jul 5, 2019
@SergiySW SergiySW added this to the V19.0 milestone Jul 5, 2019
@SergiySW SergiySW self-assigned this Jul 5, 2019
wezrule
wezrule approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nicer to use a ranged for loop

@zhyatt zhyatt merged commit 4375167 into nanocurrency:master Jul 5, 2019
argakiig pushed a commit that referenced this pull request Jul 5, 2019
@SergiySW
Improve broadcast_confirm_req_batch delays and max size (#2130)
4d9ecfb 
* Improve broadcast_confirm_req_batch delays and max size

Batch confirm_req by hash/root:
* removed increased delay for each iteration. It could cause much longer confirmations without change (+50 ms each iteration)
* larger max reps limit should allow more aggressive & faster confirmation
* better load balancing across multiple representatives in each iteration

* Better iteration
@guilhermelawless guilhermelawless mentioned this pull request Sep 4, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@argakiig argakiig argakiig approved these changes

@wezrule wezrule wezrule approved these changes

@cryptocode cryptocode Awaiting requested review from cryptocode

Assignees

@SergiySW SergiySW

Labels
bug functionality quality improvements This item indicates the need for or supplies a better way to implement existing functionality
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SergiySW @wezrule @argakiig @cryptocode @zhyatt