Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move confirm_frontiers higher up request loop #2141

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Move confirm_frontiers higher up request loop #2141

merged 1 commit into from
Jul 10, 2019

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Jul 9, 2019

@SergiySW noticed that the roots added in confirm_frontiers won't be used until the next request loop so moved them to the top.

@wezrule wezrule added the quality improvements This item indicates the need for or supplies changes that improve maintainability label Jul 9, 2019
@wezrule wezrule added this to the V20.0 milestone Jul 9, 2019
@wezrule wezrule requested a review from SergiySW July 9, 2019 10:12
@wezrule wezrule self-assigned this Jul 9, 2019
@zhyatt zhyatt modified the milestones: V20.0, V19.0 Jul 9, 2019
@wezrule wezrule merged commit dd0d43a into nanocurrency:master Jul 10, 2019
@wezrule wezrule deleted the confirm_frontiers_called_before_iterating_roots branch July 10, 2019 15:31
argakiig pushed a commit that referenced this pull request Jul 10, 2019
@wezrule
Move confirm_frontiers higher up request loop (#2141)
ed042ff
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

@clemahieu clemahieu clemahieu approved these changes

Assignees

@wezrule wezrule

Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wezrule @clemahieu @SergiySW @zhyatt