Generated votes cache size increase and upper bound #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
performance
|
I guess it can use number of voting account in node as well to prevent overflow with current settings |
guilhermelawless
force-pushed
the
generated-votes-cache-size-increase
branch
from
85baced
to
993fc00
Compare
guilhermelawless
changed the title
|
@SergiySW updated, had to make a copy of representatives in New test added and a weird clang-format change. |
guilhermelawless
force-pushed
the
generated-votes-cache-size-increase
branch
from
ea6cac0
to
442cea0
Compare
SergiySW
approved these changes
Jan 12, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory footprint is insignificant compared to the cache for votes from other representatives.