Global bandwidth limiter #2454
Merged
Global bandwidth limiter #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
functionality quality improvements
clemahieu
previously approved these changes
Dec 30, 2019
argakiig
previously approved these changes
Dec 30, 2019
guilhermelawless
dismissed stale reviews from argakiig and clemahieu
via
ae139c1
guilhermelawless
force-pushed
the
bandwidth-limiter-global
branch
2 times, most recently
from
5267f8f
to
828c785
Compare
Changes from per-channel limits to a global limiter as originally intended, and fixes a few issues with the limiter - Fix dropping condition not checking trended_rate - Fix trended_rate calculation resulting in a 20x lower value - Normalize data to the sampling period - Update and simplify validation test - Add new test using channels directly and ensuring the limit is global
…dd() and should_filter()
guilhermelawless
force-pushed
the
bandwidth-limiter-global
branch
from
f2528fa
to
3084a50
Compare
argakiig
approved these changes
Jan 1, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from per-channel limits to a global limiter as originally intended, and fixes a few issues with the limiter