Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing some intermittent failures in unit tests, and some cleanup #2465

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Fixing some intermittent failures in unit tests, and some cleanup #2465

merged 4 commits into from
Jan 14, 2020

Conversation

guilhermelawless
Copy link
Contributor

  • udp_channels::receive_action was accessing local_endpoint directly, which showed up as a race under TSAN. Fixed by using the getter.
  • By waiting for cementing, not getting any occasional failures anymore in confirmation_height.pending_observer_callbacks
  • Cleanup verbose active_transactions tests and fixing another intermittent failure in the vote_replays test, due to frontier confirmation re-starting elections (which would also be fixed by WIP: Ensure the winner of an election is always in confirmation or confirmed #2441 or similar)

Ran under TSAN+Debug with gcc.

@guilhermelawless guilhermelawless added unit test Related to a new, changed or fixed unit test sanitizers Related to thread, address or undefined sanitizers labels Jan 9, 2020
@guilhermelawless guilhermelawless added this to the V21.0 milestone Jan 9, 2020
@guilhermelawless guilhermelawless self-assigned this Jan 9, 2020
cryptocode
cryptocode previously approved these changes Jan 9, 2020
View reviewed changes
@guilhermelawless guilhermelawless changed the title Fixinng some intermittent failures in unit tests, and some cleanup Fixing some intermittent failures in unit tests, and some cleanup Jan 9, 2020
clemahieu
clemahieu previously approved these changes Jan 11, 2020
View reviewed changes
@guilhermelawless guilhermelawless removed the request for review from wezrule January 14, 2020 09:47
@guilhermelawless guilhermelawless merged commit 9a28d3a into nanocurrency:develop Jan 14, 2020
@guilhermelawless guilhermelawless deleted the test/active-transactions-cleanup branch January 14, 2020 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cryptocode cryptocode cryptocode approved these changes

@clemahieu clemahieu clemahieu left review comments

Assignees

@guilhermelawless guilhermelawless

Labels
sanitizers Related to thread, address or undefined sanitizers unit test Related to a new, changed or fixed unit test
Projects
None yet
Milestone
V21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelawless @clemahieu @cryptocode