Improve distributed_work_factory item management #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
the
quality improvements
guilhermelawless
force-pushed
the
distributed-work/simplify-container
branch
from
3a5e7ca
to
3feb024
Compare
guilhermelawless
changed the title
guilhermelawless
force-pushed
the
distributed-work/simplify-container
branch
2 times, most recently
from
4264d7b
to
8e9a8d3
Compare
- Using an unordered_multimap container of unordered_map of vectors to simplify methods. - Use ASSERT_TIMELY in tests
guilhermelawless
force-pushed
the
distributed-work/simplify-container
branch
from
8e9a8d3
to
929ca0b
Compare
guilhermelawless
force-pushed
the
distributed-work/simplify-container
branch
from
d5ac363
to
d0fd52a
Compare
wezrule
approved these changes
Jun 19, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal was initially to have each distributed work item self-erase itself from the factory's container on destruction, but some interactions with local work generation cause potential deadlocks.