-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
RocksDB tests #2836
Merged
Merged
RocksDB tests #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
added
the
universe
This item indicates the need for or supplies changes caused by external factors
label
Jul 6, 2020
Use relwithdebinfo instead
dont duplicate win relwithdebinfo run due to debug timings on win
windows actions has issues with node.bidirectional_tcp and rocksdb return early if windows and using rocksdb
instead of switching to relwithdebinfo for regular test runs
write out when a test is skipped for rocksdb
argakiig
added
database
Relates to lmdb or rocksdb
debug
Updates assisting with debugging and development efforts
labels
Aug 12, 2020
use existing function for test guards
wezrule
approved these changes
Sep 10, 2020
guilhermelawless
approved these changes
Sep 10, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable RocksDB based Test workflows
Windows RocksDB as debug is too slow, switched to RelWithDebInfo for runs
Some tests were hitting deadlines or being killed by the test subprocess timer due to timing differences.
doubled deadline factor for windows, extended timeout for nix and OSx