Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RocksDB tests #2836

Merged
merged 19 commits into from
Sep 10, 2020
Merged

RocksDB tests #2836

merged 19 commits into from
Sep 10, 2020

Conversation

argakiig
Copy link
Contributor

@argakiig argakiig commented Jul 6, 2020

Enable RocksDB based Test workflows
Windows RocksDB as debug is too slow, switched to RelWithDebInfo for runs
Some tests were hitting deadlines or being killed by the test subprocess timer due to timing differences.
doubled deadline factor for windows, extended timeout for nix and OSx

@argakiig argakiig added the universe This item indicates the need for or supplies changes caused by external factors label Jul 6, 2020
@argakiig argakiig self-assigned this Jul 6, 2020
@guilhermelawless guilhermelawless added this to the V22.0 milestone Aug 11, 2020
Russel added 8 commits August 11, 2020 14:14
dont duplicate win relwithdebinfo run due to debug timings on win
windows actions has issues with node.bidirectional_tcp and rocksdb
return early if windows and using rocksdb
instead of switching to relwithdebinfo for regular test runs
write out when a test is skipped for rocksdb
@argakiig argakiig added the unit test Related to a new, changed or fixed unit test label Aug 11, 2020
@argakiig argakiig requested a review from wezrule August 12, 2020 17:38
@argakiig argakiig added database Relates to lmdb or rocksdb debug Updates assisting with debugging and development efforts labels Aug 12, 2020
@argakiig argakiig merged commit 9ff4428 into nanocurrency:develop Sep 10, 2020
@argakiig argakiig deleted the rocksdb_tests branch September 10, 2020 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
database Relates to lmdb or rocksdb debug Updates assisting with debugging and development efforts unit test Related to a new, changed or fixed unit test universe This item indicates the need for or supplies changes caused by external factors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants