Fix inconsistent online representatives list from RPC #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This minor change increases rep crawler and online reps consistency in small ledgers with low activity - mostly for the beta network.
…a RPC The list of online reps is only used externally by RPC, but it has been noted that it is often inconsistent. This is due to clearing the list upon sampling online weight. With this change, a backup is made on each sample, and RPC will now report the list of both currently sampling reps, and the ones previously sampled.
SergiySW
approved these changes
Sep 9, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported in #2533 and @Srayman figured the problem lied in clearing the list of representatives on every sample.
Now, on sampling, a backup of the online reps is made, and the RPC will report both the backup reps and the ones currently sampling (so it can span a period between 5 and 10 minutes, depending on when it is triggered).
Online weight sampling is untouched.
Also fixes a bug affecting mostly the beta network which has a small ledger and low activity. When the hash chosen by the rep crawler query was recently confirmed, it would lead to the confirm_ack response being dismissed as a vote replay.