Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make logging election tally an optional config #2888

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Make logging election tally an optional config #2888

merged 2 commits into from
Aug 25, 2020

Conversation

guilhermelawless
Copy link
Contributor

One config for logging on expired elections, another for confirmed elections with multiple blocks, both default to false.

Since these are similar in output, added a prefix "Election expired" to differentiate them, e.g.:

[2020-Aug-19 16:02:50.492453]: Election expired
Vote tally for root E5E09C2BF257A50E8F5E823D9BAC1B70E15A6EA5EF06AC66B3F55B1AD689E1F0
Block D0170F94D063F4F06469EE8E3D7CCC126120C32948F7D56ED816A84CAEAF2521 weight 6652414849999999639484121623621009408
nano_1robotghjtaub18dmo1ihkzg9jjs53ukthxrpt5x7eie3pg7k4ahb5i1uw64 0 D0170F94D063F4F06469EE8E3D7CCC126120C32948F7D56ED816A84CAEAF2521

@guilhermelawless
Make logging election tally an optional config
6728b5b 
One config for logging on expired elections, another for confirmed elections with multiple blocks, both default to false.
@guilhermelawless guilhermelawless added this to the V21.2 milestone Aug 19, 2020
@guilhermelawless guilhermelawless self-assigned this Aug 19, 2020
SergiySW
SergiySW previously approved these changes Aug 19, 2020
View reviewed changes
@zhyatt zhyatt requested a review from wezrule August 24, 2020 18:41
clemahieu
clemahieu reviewed Aug 25, 2020
View reviewed changes
nano/node/election.cpp Outdated Show resolved Hide resolved
@guilhermelawless guilhermelawless merged commit 4ddcddd into nanocurrency:develop Aug 25, 2020
@guilhermelawless guilhermelawless deleted the logging/election-tally-configs branch August 25, 2020 14:43
guilhermelawless added a commit that referenced this pull request Sep 2, 2020
@guilhermelawless
Make logging election tally an optional config (#2888)
aab7f44 
Adapted for V21.2 patch
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

@wezrule wezrule wezrule approved these changes

@clemahieu clemahieu Awaiting requested review from clemahieu

Assignees

@guilhermelawless guilhermelawless

Labels
logging
Projects
None yet
Milestone
V21.2
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhermelawless @clemahieu @wezrule @SergiySW