Add support for defer_lock in nano::unique_lock #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs NANO_TIMED_LOCKS CMake variable > 0 to test, otherwise it defaults to using std::unique_lock This is necessary to build since nanocurrency#2901 but not caught by CI due to not using this developer-oriented feature
guilhermelawless
added
build-error
debug
|
Modified branch for a CI test here passed: https://github.com/guilhermelawless/nano-node/tree/ci/locks/defer-lock-test |
argakiig
approved these changes
Sep 2, 2020
guilhermelawless
added a commit
that referenced
this pull request
Sep 2, 2020
Needs NANO_TIMED_LOCKS CMake variable > 0 to test, otherwise it defaults to using std::unique_lock This is necessary to build since #2901 but not caught by CI due to not using this developer-oriented feature
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs NANO_TIMED_LOCKS CMake variable > 0 to test, otherwise it defaults to using std::unique_lock
This is necessary to build since #2901 but not caught by CI due to not using this developer-oriented feature