Don't delete crash dump files with --debug_generate_crash_report #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
debug
clemahieu
approved these changes
Sep 7, 2020
SergiySW
approved these changes
Sep 9, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a segmentation fault we generate a
nano_node_backtrace.dumpfile containing a stacktrace and on linux a bunch ofnano_node_crash_load_address_dump_*.txtfiles containing the load addresses for the node executable and all shared libraries. These are deleted after being used by--debug_generate_crash_report, which is maybe not what is desired so no longer deleting them. Also added some output stating what file is generated.