Fix error with work_cancel RPC request
#2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
previously approved these changes
Sep 7, 2020
@koczadly did you mean work_cancel ? Thanks for the fix, we require however that commits are GPG-signed. If you don't mind we can alternatively commit the patch ourselves with you as co-author. |
…successfully, and implement nano::error_rpc::empty_response error code to catch future errors.
|
Yeah sorry, I meant work_cancel. I've squashed and re-committed it with a signature, apologies. |
guilhermelawless
added
rpc
guilhermelawless
added
interface
clemahieu
approved these changes
Sep 10, 2020
guilhermelawless
approved these changes
Sep 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work_cancelcurrently returns no response data when successful, which results in an "Empty response" error being returned. Appears to have been broken from PR #1032.This PR adds:
{"success": ""}as the response forwork_cancelnano::error_rpc::empty_responseerror code, which is returned for empty responses (previously only an error string was passed, but without an error code).Unfortunately I've been unable to test this as I couldn't get boost to link up with VS correctly. Not sure what I'm doing wrong, so you'll have to rely on the CI results.