Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove debug_assert which is hit calling block_confirm on already confirmed block. #3031

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Remove debug_assert which is hit calling block_confirm on already confirmed block. #3031

merged 1 commit into from
Nov 4, 2020

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Nov 2, 2020

@clemahieu hit this calling block_confirm on a block already confirmed. The debug_assert relied on nothing else calling the observers which is not the case with block_confirm. We have tests which check the value of the observer stats so simpler to just remove the assert.

@wezrule wezrule added the debug Updates assisting with debugging and development efforts label Nov 2, 2020
@wezrule wezrule added this to the V22.0 milestone Nov 2, 2020
@wezrule wezrule requested a review from SergiySW November 2, 2020 16:12
@wezrule wezrule self-assigned this Nov 2, 2020
@wezrule wezrule changed the title Remove debug_assert which is hit calling block_confirm Remove debug_assert which is hit calling block_confirm on already confirmed block. Nov 2, 2020
@wezrule wezrule merged commit abfe2b0 into nanocurrency:develop Nov 4, 2020
@wezrule wezrule deleted the remove_debug_assert_conf_height branch November 4, 2020 20:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

Assignees

@wezrule wezrule

Labels
debug Updates assisting with debugging and development efforts
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wezrule @SergiySW