Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add confirmed_height in account_info RPC to be consistent #3039

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Add confirmed_height in account_info RPC to be consistent #3039

merged 1 commit into from
Dec 14, 2020

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Nov 6, 2020

#3022 added include_confirmed, there is already confirmation_height but I think to be consistent with the naming of the other new fields this should become confirmed_height in the presence of these flags so that they all have confirmed_ prefix.

@wezrule wezrule added documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls labels Nov 6, 2020
@wezrule wezrule added this to the V22.0 milestone Nov 6, 2020
@wezrule wezrule requested a review from SergiySW November 6, 2020 14:52
@wezrule wezrule self-assigned this Nov 6, 2020
@wezrule wezrule merged commit d35800a into nanocurrency:develop Dec 14, 2020
@wezrule wezrule deleted the add_confirmed_height branch December 14, 2020 15:06
@zhyatt zhyatt mentioned this pull request Feb 9, 2021
Closed
20 tasks
@zhyatt zhyatt mentioned this pull request May 12, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SergiySW SergiySW SergiySW approved these changes

Assignees

@wezrule wezrule

Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wezrule @SergiySW