Update CLI commands missing checks for reading config and overrides #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
changed the title
argakiig
previously approved these changes
Nov 17, 2020
SergiySW
reviewed
Jan 27, 2021
SergiySW
previously approved these changes
Feb 1, 2021
SergiySW
approved these changes
Feb 2, 2021
clemahieu
approved these changes
Feb 3, 2021
argakiig
approved these changes
Feb 16, 2021
deusmax
pushed a commit
to deusmax/nano-node
that referenced
this pull request
Mar 16, 2021
…anocurrency#3050) * Update missing CLI commands to check config and flags * Serg comment
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--vacuum&--snapshotwas not checking--configoverrides.--debug_profile_votes&--debug_profile_frontiers_confirmationwere not checking config file or --config overrides.Created a new
node_wrapperclass which refactors most ofinactive_nodeexcept the part about stopping active transactions because--debug_profile_votesrequires active transactions to be running