Wallet create causing crash when confirming blocks #3051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found by @PlasmaPower and nicely documented here.
I think this can be resolved by checking that the
handle
is valid insidewallet_store::begin
. There doesn't seem to be a standard way to test that so I'm just checking that themdb_dbi_flags
doesn't return an error (that function callsTXN_DBI_EXIST
which checks that the transaction and dbi arguments are correct and returns EINVAL if they aren't), a few others did that too but this one seemed to make the most sense.The new slow test added seems to more often than not hit the bug on a single iteration, but doing 5 in a loop just to increase the probability.
Couple unrelated changes I made: Added
[[maybe_unused]
inreceive_confirmed
& removed an unnecessarystd::move
inwallets::queue_wallet_action