Add debug/release_assert overloads which output error message strings #3077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
release_assert
MACRO doesn't give an indication about what the actual error which caused it is, in the case of error codes it can be useful to know what they are. This adds a release_assert (and debug_assert) MACRO overload which accepts astring_view
which will be output to the stderr in the case there is an error. This is now used in various places in database transactions for lmdb/rocksdb to catch more common issues seen. Inblockstore_partial.hpp
a new macrorelease_assert_success
is added which conditionally creates the string as it could be wasteful to always construct it when it is only actually output in error cases.