Wallet store adhoc keys inconsistency with reps container #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
force-pushed
the
adhoc_rep_inconsistency
branch
from
bfff9bd
to
452931d
Compare
SergiySW
approved these changes
Jan 26, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a wallet key is added in
insert_adhocbut it's possible that the write transaction hasn't commited while therepresentativescontainer has been updated. Ifnano::wallets::compute_repsis called at the same time therepresentativesare cleared and never repopulated from the store. This was made more evident with test failures in #2871.Also modifying the
write_transactionso thatcommit ()can be called without having to renew it before destruction, so it operates similarly tostd::unique_lockfor instance.There is also an issue with deterministic wallet inserts, which can be handled separately (as well as adding tests)