Final votes #3134
Merged
Final votes #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… uses a double consensus pass before arriving at confirmation. The final vote pass is limited to issuing a single vote which cannot be changed and only following confirmation in the final vote pass is a transaction confirmed.
…on forced confirmation
SergiySW
previously approved these changes
Mar 11, 2021
|
Can both the sequence and timestamps be used but have the timestamp include the actual timestamp the vote was generated? This would help in analyzing votes for confirmations to know when a final vote was generated compared to others. The sequence could continue to be used to differentiate newer/final votes. |
Srayman
pushed a commit
to Srayman/nano-node
that referenced
this pull request
Apr 20, 2021
# Conflicts: # nano/core_test/active_transactions.cpp # nano/core_test/node.cpp # nano/node/active_transactions.cpp # nano/node/blockprocessor.cpp # nano/node/bootstrap/bootstrap_frontier.cpp # nano/node/bootstrap/bootstrap_legacy.cpp # nano/node/confirmation_height_bounded.cpp # nano/node/confirmation_height_processor.cpp # nano/node/confirmation_height_unbounded.cpp # nano/node/election.cpp # nano/node/node.cpp # nano/node/prioritization.cpp # nano/node/request_aggregator.cpp # nano/node/voting.cpp # nano/secure/common.cpp
# Conflicts: # nano/node/active_transactions.cpp # nano/node/node.cpp
Check if scheduler is stopped when blocking on ::flush.
That would require a second field in the vote and a new vote format with an upgrade etc. |
# Conflicts: # nano/node/active_transactions.cpp # nano/node/election.cpp # nano/node/election.hpp
# Conflicts: # nano/node/election_scheduler.cpp
SergiySW
approved these changes
May 6, 2021
zhyatt
added
the
major
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a mitigation when handling specific fork situations and uses a double consensus pass before arriving at confirmation.
Thank you to @PlasmaPower for the initial design and @Srayman for help with patch testing.